feat: notations for file system paths #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new file system path notations and updates existing notation regex patterns to better handle leading delimiters, while also updating test cases and notation implementations.
- Introduces UnixPath and WindowsPath notation implementations and corresponding tests
- Updates ScreamingSnakeCase and SnakeCase regex patterns with negative lookbehind
- Revises JavaNotations by removing the "data" modifier from JavaTypeName, and adjusts BaseStringNotation to include empty parts
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/kotlin/NotationsTest.kt | Updated test cases for underscore-prefixed words in snake case notations |
| src/test/kotlin/FileSystemNotationsTest.kt | Added new tests for Unix and Windows path notations |
| src/main/kotlin/Notations.kt | Updated regex patterns in ScreamingSnakeCase and SnakeCase |
| src/main/kotlin/JavaNotations.kt | Changed JavaTypeName from a data object to a standard object |
| src/main/kotlin/FileSystemNotations.kt | Introduced new notations for Unix and Windows file system paths |
| src/main/kotlin/BaseStringNotation.kt | Modified parsing behavior to include empty parts, facilitating absolute path support |
Comments suppressed due to low confidence (2)
src/main/kotlin/BaseStringNotation.kt:15
- The removal of the isNotBlank filter in the split operation changes the behavior by including empty parts (used for absolute paths). Consider updating the documentation to clarify this design decision and its implications.
Word(sourceString.split(splitAt).asSequence().mapIndexed(::transformPartAfterParse))
src/main/kotlin/JavaNotations.kt:14
- [nitpick] The change from 'data object' to 'object' for JavaTypeName is noted; it would be beneficial to include a comment explaining the rationale behind this change to aid future maintenance.
object JavaTypeName : StringNotation by UpperCamelCase {
jGleitz
force-pushed
the
file-system-notation
branch
from
3fc9495 to
6e42451
Compare
jGleitz
force-pushed
the
file-system-notation
branch
from
6e42451 to
099fd18
Compare
|
Owner
Author
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.